-
Notifications
You must be signed in to change notification settings - Fork 3
Increase minimum python version #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Python version requirement in the project metadata was updated to exclude Python 3.9, now supporting only versions greater than 3.9 and less than 3.14. No other changes to code, exports, or public entities were made. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
19-19
: Prefer>=3.10
over>3.9
for clarity & tooling compatibilityThe PEP 440 spec allows both, but most tooling and humans expect the lower bound to be expressed as the first inclusive minor version you truly support (
>=3.10
).
Using>3.9
is semantically identical yet less explicit and can confuse constraint solvers or readers who quickly grep for a>=
.-requires-python = ">3.9, <3.14" +requires-python = ">=3.10, <3.14"Also double-check that:
- CI matrices / build wheels have dropped 3.9.
- Docs and README no longer advertise 3.9 support.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 31 31
Lines 1383 1383
=======================================
Hits 1341 1341
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit