Skip to content

Warn when max workers is not set #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2025
Merged

Warn when max workers is not set #753

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d5a978
warn about max workers
jan-janssen Jul 21, 2025
4698eb4
Merge remote-tracking branch 'origin/main' into test
jan-janssen Jul 21, 2025
c1c0039
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 21, 2025
fbd71af
fix return
jan-janssen Jul 21, 2025
44fd4bc
Merge remote-tracking branch 'origin/test' into test
jan-janssen Jul 21, 2025
3f98455
Set stacklevel
jan-janssen Jul 21, 2025
8fee4c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion executorlib/standalone/inputcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os.path
from concurrent.futures import Executor
from typing import Callable, Optional
from warnings import warn


def check_oversubscribe(oversubscribe: bool) -> None:
Expand Down Expand Up @@ -190,7 +191,13 @@ def validate_number_of_cores(
"Block allocation requires a fixed set of computational resources. Neither max_cores nor max_workers are defined."
)
else:
return multiprocessing.cpu_count()
max_workers = multiprocessing.cpu_count()
warn(
"max_workers parameter is not set, set default based on CPU count to: max_workers="
+ str(max_workers),
stacklevel=2,
)
return max_workers


def check_file_exists(file_name: Optional[str]):
Expand Down
Loading