Rename flux_executor_pmi_mode to pmi_mode #762

jan-janssen · 2025-07-27T13:39:50Z

No description provided.

…rm_mpi_interface

…mpi_interface

coderabbitai · 2025-07-27T13:39:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch pmix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jan-janssen · 2025-07-27T13:46:27Z

When I use --mpi=pmix_v5 with openmpi v5 I get the following error:

MPI plugin types are...
	none
	pmix
	cray_shasta
	pmi2
specific pmix plugin versions available: pmix_v5
srun: error:  mpi/pmix_v5: init: (null) [0]: mpi_pmix.c:193: pmi/pmix: can not load PMIx library
srun: error: Couldn't load specified plugin name for mpi/pmix_v5: Plugin init() callback failed
srun: error: MPI: Cannot create context for mpi/pmix_v5
srun: error: MPI: Unable to load any plugin
srun: error: Invalid MPI type 'pmix_v5', --mpi=list for acceptable types

jan-janssen · 2025-07-27T13:58:34Z

When I use openmpi v5 with --mpi=pmi2 then I get the following error:

MPI plugin types are...
	none
	pmix
	cray_shasta
	pmi2
specific pmix plugin versions available: pmix_v5
No PMIx server was reachable, but a PMI1/2 was detected.
If srun is being used to launch application,  2 singletons will be started.

jan-janssen · 2025-07-27T15:46:59Z

srun: error: slurm_receive_msgs: [[localhost]:6818] failed: Socket timed out on send/recv operation
srun: error: Task launch for StepId=3.0 failed on node localhost: Socket timed out on send/recv operation
srun: error: Application launch failed: Socket timed out on send/recv operation
srun: Job step aborted

codecov · 2025-07-27T16:15:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (2545358) to head (98cc5f5).
⚠️ Report is 1 commits behind head on parallel_file_executor.

Additional details and impacted files

@@                    Coverage Diff                     @@
##           parallel_file_executor     #762      +/-   ##
==========================================================
+ Coverage                   97.45%   97.47%   +0.01%     
==========================================================
  Files                          32       32              
  Lines                        1414     1423       +9     
==========================================================
+ Hits                         1378     1387       +9     
  Misses                         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

review-notebook-app · 2025-07-27T17:49:45Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

for more information, see https://pre-commit.ci

* file executor fix parallel execution * add command tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * tests only run when mpi4py is available * fix windows tests * fix openmpi by adding pmi support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * extend tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Rename flux_executor_pmi_mode to pmi_mode (#762) * Debug slurm pmi options * Update pipeline.yml * disable MPI parallel test * sinfo * update output * add mpi parallel test * core validation is only possible on compute node not on login node * fix test * enforce pmix for testing * Update slurmspawner.py * downgrade to openmpi * remove pmi setting * use slurm environment * Try pmix again * Update slurmspawner.py * Update slurmspawner.py * Update pipeline.yml * Update pipeline.yml * Update slurmspawner.py * Update pipeline.yml * use slrum args * extend test * fix tests * Add executor_pmi_mode option * check all files * fixes * extend tests * rename to pmi_mode * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

jan-janssen and others added 16 commits July 27, 2025 12:32

Debug slurm pmi options

6edd2c1

Update pipeline.yml

756e55c

Merge remote-tracking branch 'origin/parallel_file_executor' into slu…

34c87d3

…rm_mpi_interface

disable MPI parallel test

ec507ec

sinfo

b3ae43e

update output

21afba9

add mpi parallel test

d38dda3

core validation is only possible on compute node not on login node

848da88

fix test

48000d4

enforce pmix for testing

a86b5df

Update slurmspawner.py

2990d11

downgrade to openmpi

dbcd364

Merge remote-tracking branch 'origin/slurm_mpi_interface' into slurm_…

2084b99

…mpi_interface

remove pmi setting

4b374b4

use slurm environment

1571c6a

Try pmix again

b3b393c

jan-janssen marked this pull request as draft July 27, 2025 13:41

Update slurmspawner.py

0dc0ecc

jan-janssen closed this Jul 27, 2025

jan-janssen deleted the pmix branch July 27, 2025 14:12

jan-janssen restored the pmix branch July 27, 2025 15:31

jan-janssen reopened this Jul 27, 2025

Update slurmspawner.py

97125e5

jan-janssen changed the title ~~Try openmpi with pmix~~ Debug slurm - with openmpi v5 Jul 27, 2025

Update pipeline.yml

58d152f

Update pipeline.yml

fddf4a6

jan-janssen added 2 commits July 27, 2025 17:58

Update slurmspawner.py

0d248b7

Update pipeline.yml

0c2d3f7

use slrum args

1c89a16

jan-janssen force-pushed the pmix branch from a8041cf to 1c89a16 Compare July 27, 2025 16:38

jan-janssen added 4 commits July 27, 2025 18:46

extend test

fcf4394

fix tests

1d33bb5

Add executor_pmi_mode option

3e08db9

check all files

f4102d8

jan-janssen added 2 commits July 27, 2025 19:53

fixes

0b693cf

extend tests

4e73041

jan-janssen marked this pull request as ready for review July 27, 2025 18:01

jan-janssen changed the title ~~Debug slurm - with openmpi v5~~ Rename flux_executor_pmi_mode to executor_pmi_mode Jul 27, 2025

jan-janssen and others added 2 commits July 27, 2025 20:25

rename to pmi_mode

21e4465

[pre-commit.ci] auto fixes from pre-commit.com hooks

029bd8a

for more information, see https://pre-commit.ci

jan-janssen changed the title ~~Rename flux_executor_pmi_mode to executor_pmi_mode~~ Rename flux_executor_pmi_mode to pmi_mode Jul 27, 2025

jan-janssen added 2 commits July 27, 2025 20:26

fixes

27735e9

Merge remote-tracking branch 'origin/pmix' into pmix

98cc5f5

jan-janssen closed this Jul 27, 2025

jan-janssen reopened this Jul 27, 2025

jan-janssen merged commit 3646610 into parallel_file_executor Jul 27, 2025
55 checks passed

jan-janssen deleted the pmix branch July 27, 2025 18:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename flux_executor_pmi_mode to pmi_mode #762

Rename flux_executor_pmi_mode to pmi_mode #762

Uh oh!

jan-janssen commented Jul 27, 2025

Uh oh!

coderabbitai bot commented Jul 27, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

jan-janssen commented Jul 27, 2025 •

edited

Loading

Uh oh!

jan-janssen commented Jul 27, 2025 •

edited

Loading

Uh oh!

jan-janssen commented Jul 27, 2025

Uh oh!

codecov bot commented Jul 27, 2025 •

edited

Loading

Uh oh!

review-notebook-app bot commented Jul 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rename flux_executor_pmi_mode to pmi_mode #762

Rename flux_executor_pmi_mode to pmi_mode #762

Uh oh!

Conversation

jan-janssen commented Jul 27, 2025

Uh oh!

coderabbitai bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

jan-janssen commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jan-janssen commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jan-janssen commented Jul 27, 2025

Uh oh!

codecov bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

review-notebook-app bot commented Jul 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jul 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

jan-janssen commented Jul 27, 2025 •

edited

Loading

jan-janssen commented Jul 27, 2025 •

edited

Loading

codecov bot commented Jul 27, 2025 •

edited

Loading