-
Notifications
You must be signed in to change notification settings - Fork 3
Update pysqa to 0.3.0 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 33 33
Lines 1460 1460
=======================================
Hits 1424 1424
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.ci_support/environment-integration.yml(1 hunks).ci_support/environment-mpich.yml(1 hunks).ci_support/environment-openmpi.yml(1 hunks)binder/environment.yml(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.11)
- GitHub Check: unittest_slurm_mpich
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.12)
- GitHub Check: unittest_flux_mpich
- GitHub Check: unittest_openmpi (macos-latest, 3.13)
- GitHub Check: notebooks_integration
- GitHub Check: unittest_mpich (ubuntu-latest, 3.11)
- GitHub Check: unittest_win
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
- GitHub Check: unittest_mpich (macos-latest, 3.13)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.13)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.12)
- GitHub Check: unittest_flux_openmpi
- GitHub Check: notebooks
🔇 Additional comments (4)
binder/environment.yml (1)
18-18: Dependency bump looks goodThe Binder environment is now consistent with the other lock files after pinning
pysqato 0.3.0..ci_support/environment-openmpi.yml (1)
13-13: CI environment syncedOpenMPI matrix correctly tracks
pysqa0.3.0. No further action required..ci_support/environment-mpich.yml (1)
14-14: CI environment syncedMPICH matrix correctly tracks
pysqa0.3.0. No further action required..ci_support/environment-integration.yml (1)
18-18: Integration environment syncedThe integration image now pins
pysqato 0.3.0, keeping all environments consistent.
| "pysqa==0.3.0", | ||
| "h5py==3.14.0", | ||
| ] | ||
| all = [ | ||
| "mpi4py==4.0.1", | ||
| "pysqa==0.2.7", | ||
| "pysqa==0.3.0", | ||
| "h5py==3.14.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify that pysqa==0.3.0 is published for all packaging channels you rely on
The pin looks fine, but if pysqa 0.3.0 is missing for any of the required Python versions or platforms (e.g. conda-forge builds for Linux/Mac/Win), CI and downstream users will break.
Please double-check availability before merging.
🏁 Script executed:
#!/usr/bin/env bash
# Validate that pysqa 0.3.0 exists on both PyPI and conda-forge
set -euo pipefail
echo "PyPI:"
curl -s https://pypi.org/pypi/pysqa/json | jq -r '.releases["0.3.0"] | length'
echo -e "\nconda-forge (linux-64):"
curl -s https://conda.anaconda.org/conda-forge/linux-64/repodata.json \
| jq -r '.packages | to_entries[] | select(.value.name=="pysqa" and .value.version=="0.3.0") | .value.subdir' \
| head -n 5Length of output: 378
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
for subdir in linux-64 osx-64 win-64; do
echo "conda-forge ($subdir):"
curl -s https://conda.anaconda.org/conda-forge/$subdir/repodata.json \
| jq -r '
.packages
| to_entries[]
| select(.value.name=="pysqa" and .value.version=="0.3.0")
| .value.subdir
' \
| sort -u || echo "none found"
echo
doneLength of output: 683
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
for subdir in noarch linux-64 osx-64 win-64; do
echo "conda-forge ($subdir):"
curl -s "https://conda.anaconda.org/conda-forge/$subdir/repodata.json" \
| jq -r '
.packages
| to_entries[]
| select(.value.name=="pysqa" and .value.version=="0.3.0")
| .value.subdir
' \
| sort -u || echo "none found"
echo
doneLength of output: 1028
pysqa 0.3.0 is available on PyPI but missing from conda-forge
We found two artifacts for pysqa 0.3.0 on PyPI, but no packages in any of these conda-forge channels:
- noarch: none found
- linux-64: none found
- osx-64: none found
- win-64: none found
This will break any CI or downstream workflows relying on conda-forge. Please either:
- Publish pysqa 0.3.0 to conda-forge
- Remove or relax the conda-forge pin in pyproject.toml
- Or document that pysqa must be installed from PyPI only
File: pyproject.toml Lines 55–61
🤖 Prompt for AI Agents
In pyproject.toml around lines 55 to 61, the dependency pysqa==0.3.0 is pinned
but is not available on conda-forge, which will cause CI or downstream workflows
relying on conda-forge to fail. To fix this, either remove or relax the version
pin for pysqa in the conda-forge dependencies section, or add documentation
specifying that pysqa must be installed from PyPI only, or alternatively publish
pysqa 0.3.0 to conda-forge if possible.
Summary by CodeRabbit
pysqapackage dependency from 0.2.7 to 0.3.0 across all relevant environments and optional dependency groups.