Skip to content

map(): Evaluate generator within with-statement #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

map(): Evaluate generator within with-statement #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/test_fluxjobexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ def test_single_task(self):
block_allocation=True,
pmi_mode=pmi,
) as p:
output = p.map(mpi_funct, [1, 2, 3])
output = list(p.map(mpi_funct, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[[(1, 2, 0), (1, 2, 1)], [(2, 2, 0), (2, 2, 1)], [(3, 2, 0), (3, 2, 1)]],
)

Expand All @@ -122,9 +122,9 @@ def test_output_files_cwd(self):
block_allocation=True,
flux_log_files=True,
) as p:
output = p.map(calc, [1, 2, 3])
output = list(p.map(calc, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[1, 2, 3],
)
self.assertTrue(os.path.exists(file_stdout))
Expand All @@ -142,9 +142,9 @@ def test_output_files_abs(self):
block_allocation=True,
flux_log_files=True,
) as p:
output = p.map(calc, [1, 2, 3])
output = list(p.map(calc, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[1, 2, 3],
)
self.assertTrue(os.path.exists(file_stdout))
Expand Down
4 changes: 2 additions & 2 deletions tests/test_fluxpythonspawner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ def test_single_task(self):
},
spawner=FluxPythonSpawner,
) as p:
output = p.map(mpi_funct, [1, 2, 3])
output = list(p.map(mpi_funct, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[[(1, 2, 0), (1, 2, 1)], [(2, 2, 0), (2, 2, 1)], [(3, 2, 0), (3, 2, 1)]],
)

Expand Down
8 changes: 4 additions & 4 deletions tests/test_mpiexecspawner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,8 @@ def test_pool_serial_map(self):
executor_kwargs={"cores": 1},
spawner=MpiExecSpawner,
) as p:
output = p.map(calc_array, [1, 2, 3])
self.assertEqual(list(output), [np.array(1), np.array(4), np.array(9)])
output = list(p.map(calc_array, [1, 2, 3]))
self.assertEqual(output, [np.array(1), np.array(4), np.array(9)])

def test_executor_exception(self):
with self.assertRaises(RuntimeError):
Expand Down Expand Up @@ -430,9 +430,9 @@ def test_pool_multi_core_map(self):
executor_kwargs={"cores": 2},
spawner=MpiExecSpawner,
) as p:
output = p.map(mpi_funct, [1, 2, 3])
output = list(p.map(mpi_funct, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[[(1, 2, 0), (1, 2, 1)], [(2, 2, 0), (2, 2, 1)], [(3, 2, 0), (3, 2, 1)]],
)

Expand Down
4 changes: 2 additions & 2 deletions tests/test_singlenodeexecutor_mpi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ def test_output_files_cwd(self):
resource_dict={"cores": 1, "cwd": dirname},
block_allocation=True,
) as p:
output = p.map(calc, [1, 2, 3])
output = list(p.map(calc, [1, 2, 3]))
self.assertEqual(
list(output),
output,
[1, 2, 3],
)

Expand Down
Loading