Base stuff #6
Merged
Base stuff #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a util class for import warnings * Add docstring * Add test * Add context manager Co-authored-by: Marvin Poul <ponder@creshal.de>
Decorating a function with the Deprecator can change its instance attributes (if you pass arguments when decorating). That means that when decorating different functions the warning shown used only the arguments from the last call to the deprecator instance. This is fixed now by copying the deprecator instance before wrapping the given function.
Copy deprecator instance on decorating
We had a pattern for this in multiple places (talking to the database or hdf5 file).
Add numpy equality check for unit tests
add ruff linter
…est -sfp tests/utils/test_error.py
Catching warnings can be janky, e.g. if some upstream dependency starts getting a deprecation warning (possible even depending only on the standard library, as we may update python itself), so provide a private way to convert those warnings into a hard failure for test purposes.
None of it was shared
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
Pull Request Test Coverage Report for Build 9272728772Details
💛 - Coveralls |
pmrv
reviewed
May 28, 2024
pmrv
reviewed
May 28, 2024
samwaseda
approved these changes
May 28, 2024
Co-authored-by: Marvin Poul <ponder@creshal.de>
Co-authored-by: Marvin Poul <ponder@creshal.de>
Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>
Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>
Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @pmrv's suggestion, adding from
pyiron_base:ImportAlarmDeprecatorretry@pmrv, catching warnings in the tests can be janky -- e.g. because some dependency introduces some deprecation error of its own or whatever -- so I made a private flag to convert the deprecator warnings into hard errors and then test explicitly for that. User facing stuff remains totally unchanged.