ImportAlarm: Expose _fail_on_warning and rename #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes there is nothing useful to be done on a missing (optional) dependency, but the current behavior forces users to handle this case in the decorated function itself. With this change, this case can simply raise an exception in case e.g. a function is called that is only part of a package API if the depedency is met.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 13 13
Lines 537 537
=======================================
Hits 511 511
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liamhuber
approved these changes
Sep 16, 2025
|
Mh, I had understood 'no-deps' as in no outside dependencies, but I agree no interdependencies would still be nice to break things out in the future. Either way, the flag was actually private before, I could also just drop it. |
It was a private flag anyway.
|
Yeah, since it's private let's just delay the decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is nothing useful to be done on a missing (optional) dependency, but the current behavior forces users to handle this case in the decorated function itself. With this change, this case can simply raise an exception in case e.g. a function is called that is only part of a package API if the depedency is met.