-
Notifications
You must be signed in to change notification settings - Fork 0
Retrieve objects from strings robustly #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
In case the very first module bombs Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 94.81% 95.12% +0.30%
==========================================
Files 13 14 +1
Lines 540 574 +34
==========================================
+ Hits 512 546 +34
Misses 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PyCharm is treating the suite differently than the GitHub CI Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
And test it to complete coverage Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check the tests, one very small nit which could be added. LGTM!
Co-authored-by: Niklas Siemer <70580458+niklassiemer@users.noreply.github.com>
I wrote this for
bagofholding, but wound up copy-pasting that also intopyiron_core. There I found an edge case I hadn't run into. In general, this concept of getting stuff back from a string "serialization" has come up a few times, and there are a few nasty edge cases to think about. I feel it would be helpful to do it once, right, here.