Skip to content

Conversation

@liamhuber
Copy link
Member

I wrote this for bagofholding, but wound up copy-pasting that also into pyiron_core. There I found an edge case I hadn't run into. In general, this concept of getting stuff back from a string "serialization" has come up a few times, and there are a few nasty edge cases to think about. I feel it would be helpful to do it once, right, here.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
In case the very first module bombs

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Claude Opus did the heavy lifting. It did a good job, but there was still some of fiddling around the edges and a couple places where it really misunderstood meaning. Still, sped things up.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber liamhuber requested a review from niklassiemer October 2, 2025 21:21
@liamhuber liamhuber added the enhancement New feature or request label Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_snippets/retrieve

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.12%. Comparing base (7fb974a) to head (46be80e).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   94.81%   95.12%   +0.30%     
==========================================
  Files          13       14       +1     
  Lines         540      574      +34     
==========================================
+ Hits          512      546      +34     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PyCharm is treating the suite differently than the GitHub CI

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
And test it to complete coverage

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the tests, one very small nit which could be added. LGTM!

liamhuber and others added 2 commits October 3, 2025 06:08
Co-authored-by: Niklas Siemer <70580458+niklassiemer@users.noreply.github.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber liamhuber merged commit fc35c87 into main Oct 3, 2025
20 of 21 checks passed
@liamhuber liamhuber deleted the retrieve branch October 3, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants