Skip to content

Conversation

@liamhuber
Copy link
Member

@liamhuber liamhuber commented Feb 20, 2024

Still, this leans directly on the storage provided by pyiron_base.jobs.flex.PythonFunctionContainerJob

Breaking: removes the create_job_with_python_wrapper interface from pyiron_workflow.job.

@liamhuber liamhuber changed the title Replace the wrapper job with a more robust job subclass [breaking] Replace the wrapper job with a more robust job subclass Feb 20, 2024
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/node_output_job

@codacy-production
Copy link

codacy-production bot commented Feb 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 83.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a6efda7) 3065 2659 86.75%
Head commit (8a84f60) 3090 (+25) 2679 (+20) 86.70% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#222) 37 31 83.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7979306570

Details

  • -2 of 35 (94.29%) changed or added relevant lines in 2 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 91.348%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_workflow/job.py 30 32 93.75%
Files with Coverage Reduction New Missed Lines %
job.py 9 89.9%
channels.py 11 94.39%
Totals Coverage Status
Change from base Build 7978218853: 0.2%
Covered Lines: 5733
Relevant Lines: 6276

💛 - Coveralls

I suspect what's happening is `DataContainer` is leaning on `h5io_browser`'s `use_state` defaults, but I won't dig into it now.
@liamhuber liamhuber added the format_black trigger the Black formatting bot label Feb 20, 2024
@liamhuber liamhuber merged commit ab25d67 into main Feb 20, 2024
@liamhuber liamhuber deleted the node_output_job branch February 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

format_black trigger the Black formatting bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants