Skip to content

Conversation

@samwaseda
Copy link
Member

Code:

def f(a, b, c):
    return a

function_node(f, a=1, b=2, d=3)

Previous error message:
ValueError: Tried to set input ['a', 'b', 'd'], but one or more label was not found among available inputs: ['a', 'b', 'c']

New error message:
ValueError: {'d'} not found among available inputs: ['a', 'b', 'c']

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/get_close_matches_io

@samwaseda samwaseda changed the title update error message Update error message of IO when an inexistent arg is used Sep 22, 2024
@codacy-production
Copy link

codacy-production bot commented Sep 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (243c7f1) 3286 2999 91.27%
Head commit (11a8a05) 3290 (+4) 3003 (+4) 91.28% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#469) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 10983950053

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.277%

Totals Coverage Status
Change from base Build 10981912838: 0.01%
Covered Lines: 3003
Relevant Lines: 3290

💛 - Coveralls

Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, another pure improvement 🚀

Looks like the new method can be staticmethod; please verify and make it one if that's the case

@samwaseda
Copy link
Member Author

Looks like the new method can be staticmethod; please verify and make it one if that's the case

Yep you are right. I changed it

@samwaseda samwaseda merged commit f70bac9 into main Sep 22, 2024
@samwaseda samwaseda deleted the get_close_matches_io branch September 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants