Only intra-graph connections

[liamhuber]

Enforce the exclusive connection of nodes with the same (or None) parent.

This was always the intent. In order facilitate passing connections (but not a parent=) at instantiation time, when connections are made from a parented node to an orphan node, the orphan gets its counterpart's parent. This results in one gross side effect: making connections from an un-parented node to a node inside a macro after the macro has finished instantiating adds the un-parented node as a child of the macro! This has no functional impact since the execution graph of the macro is not updated post-instantiation, so that node just sits there taking up memory, but it is still sub-optimal.

Closes #587

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions]

👈 Launch a binder notebook on branch pyiron/pyiron_workflow/intra_graph_connections

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (99f0472) to head (5b4853b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   93.33%   93.23%   -0.11%     
==========================================
  Files          34       34              
  Lines        3586     3606      +20     
==========================================
+ Hits         3347     3362      +15     
- Misses        239      244       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[liamhuber]

The missing coverage is actually relevant; before merging I should extend the test to include such a callback-triggering failure case.

[liamhuber]

Also let's replace the callback class with with contextlib.ExitStack()

[liamhuber]

Also let's replace the callback class with with contextlib.ExitStack()

No, ExitStack triggers all its callback whenever we exit the stack context; I need something that only triggers callbacks when we hit an exception inside the context.

I could still use a context manager, but for now I only have a single exception anyway. It might be interesting to replace all such cleanup tasks with an exception-cleanup-manager, but that can be a separate PR.

EDIT: Better than here, if it's worth doing it's probably worth doing in snippets pyiron/pyiron_snippets#59