Skip to content

Remove the need to call start_process() manually #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Remove the need to call start_process() manually #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pylammpsmpi/wrapper/concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ def __init__(
self._cmdargs = cmdargs
self._queue_adapter = queue_adapter
self._queue_adapter_kwargs = queue_adapter_kwargs
self._start_process()

def start_process(self):
def _start_process(self):
self._process = RaisingThread(
target=execute_async,
kwargs={
Expand Down
1 change: 0 additions & 1 deletion pylammpsmpi/wrapper/extended.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ def __init__(
queue_adapter=queue_adapter,
queue_adapter_kwargs=queue_adapter_kwargs,
)
self.lmp.start_process()

def __getattr__(self, name):
"""
Expand Down
1 change: 0 additions & 1 deletion tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def setUpClass(cls):
working_directory=".",
cmdargs=["-cite", cls.citation_file]
)
cls.lmp.start_process()
cls.lmp.file(cls.lammps_file)

@classmethod
Expand Down
1 change: 0 additions & 1 deletion tests/test_concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def setUpClass(cls):
working_directory=".",
cmdargs=["-cite", cls.citation_file]
)
cls.lmp.start_process()
cls.lmp.file(cls.lammps_file).result()

@classmethod
Expand Down