Skip to content

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Mar 4, 2022

The MPI run command uses oversubscribe option which is only useful if Dask clusters are used. However, this option fails with mpich. I added a small workaround, which only uses this option if a Dask cluster is used.

This fix could be the solution for this and this.

@niklassiemer Could you please help with the tag for black formatting?

@niklassiemer
Copy link
Member

Sure, I completely forgot to push that tag and workflow to all repos.

@jan-janssen
Copy link
Member

The MPI run command uses oversubscribe option which is only useful if Dask clusters are used. However, this option fails with mpich. I added a small workaround, which only uses this option if a Dask cluster is used.

To my knowledge the whole trick of communicating via stdin and stdout only works with OpenMPI but not mpich. At least for large structures - that is why I did not care about mpich support so far.

@srmnitc
Copy link
Member Author

srmnitc commented Mar 7, 2022

I was not aware of this; then there is really need for this change. I will run a few more tests before we go ahead and close it.

@jan-janssen
Copy link
Member

I was not aware of this; then there is really need for this change. I will run a few more tests before we go ahead and close it.

As I see no progress on this pull request I close it now. Feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants