-
Couldn't load subscription status.
- Fork 8
Follow Python standard packaging guidelines #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe repository migrates from a root-level package structure to a src-layout by updating all path references in CI/CD workflows and packaging configuration to point to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The changes follow a consistent, repetitive pattern of path updates across multiple files. No complex logic or control flow modifications are present—verification involves ensuring all occurrences of the package path were uniformly updated and no references were missed. Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 92.46% 92.19% -0.27%
==========================================
Files 17 19 +2
Lines 1008 1025 +17
==========================================
+ Hits 932 945 +13
- Misses 76 80 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pipeline.yml (1)
56-58: Align mypy path format with Black for consistency.The mypy invocation at line 56 uses
src/${{ github.event.repository.name }}while the Black steps use./src/${{ github.event.repository.name }}. Both formats resolve identically in shell, but aligning them to./src/...would improve consistency and explicitness across the workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/deploy.yml(1 hunks).github/workflows/pipeline.yml(3 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unittest_matrix (windows-latest, 3.14)
- GitHub Check: unittest_slurm
🔇 Additional comments (6)
.github/workflows/pipeline.yml (1)
14-16: Black src paths correctly updated for src-layout.Both Black steps properly reference
./src/${{ github.event.repository.name }}to check and format code in the new source layout.Also applies to: 28-32
.github/workflows/deploy.yml (1)
34-34: Version file path correctly updated for src-layout.The git update-index exclusion properly references
src/pysqa/_version.py, aligning with the relocated version file in the packaging configuration.pyproject.toml (4)
96-99: Hatch build include path correctly updated for src-layout.The include directive now references
src/pysqaas expected.
101-102: VCS version-file path correctly updated.The version-file directive now references
src/pysqa/_version.pyas expected.
104-112: Source and wheel package paths correctly updated for src-layout.Both sdist and wheel configurations now properly reference
src/pysqa.
114-120: ****The coverage source configuration at line 119 is actually correct and follows best practices for src-layout projects. According to coverage documentation, using the package name is often best with src-layout because coverage will only consider importable modules. The current configuration of
source = ["pysqa"]appropriately references the package name rather than the directory path, which is the recommended approach. No changes are needed.Likely an incorrect or invalid review comment.
Summary by CodeRabbit