Skip to content

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Sep 29, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI to run tests on Python 3.13 across Linux, macOS, and Windows; added an Ubuntu 3.13 job, aligned matrix labels, and adjusted coverage upload to target the 3.13 job.
  • Documentation
    • Declared official Python 3.13 support in project metadata and classifiers; expanded compatibility range to >=3.9, <3.14.

@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updates CI workflow to add and prefer Python 3.13 across matrices and coverage conditions; expands project metadata to declare compatibility with Python 3.13 (requires-python <3.14) and adds the 3.13 classifier.

Changes

Cohort / File(s) Summary
CI workflow: Python matrix & coverage
.github/workflows/pipeline.yml
Bumps Python entries from 3.12 → 3.13 across setup and unittest matrices (Windows/macOS/Ubuntu), adds linux-64-py-3-13 matrix entry, updates coverage upload condition to target 3.13, and preserves a separate Ubuntu 3.12 entry.
Project metadata: Python compatibility
pyproject.toml
Expands requires-python from ">=3.9, <3.13" to ">=3.9, <3.14" and adds classifier Programming Language :: Python :: 3.13.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer (PR)
    participant CI as GitHub Actions
    participant Runner as Matrix Runner
    participant Test as Test Steps
    participant Cov as Coverage Upload

    Dev->>CI: Push PR with updated pipeline.yml & pyproject.toml
    CI->>Runner: Expand matrix (includes python 3.13 entries)
    Runner->>Test: Setup environment (mambaforge / Python 3.13)
    Test->>Test: Run unit tests
    alt on linux-64-py-3-13 success
        Test->>Cov: Upload coverage report (condition matches 3.13)
    else other entries
        Test->>Cov: Skip or different coverage logic
    end
    Runner->>CI: Report status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws in CI night,
3.13 hops in, all tests alight.
Toml stretches, bounds the frame,
Classifiers cheer the new name.
Pipelines hum — carrots in sight! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Test with Python 3.13” succinctly and accurately conveys the primary intent of the changeset, which is to update the CI workflows and project metadata to support and test against Python 3.13.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch py313

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19fd25e and 8658bbb.

📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jan-janssen
Copy link
Member Author

jan-janssen commented Sep 29, 2025

@srmnitc Currently pyscal3 does not support Python 3.13, can you take a look at this?

      ├─ pyscal3 =3.3.0 * is installable with the potential options
      │  ├─ pyscal3 3.3.0 would require
      │  │  └─ python >=3.9,<3.10.0a0 *, which can be installed;
      │  ├─ pyscal3 3.3.0 would require
      │  │  └─ python >=3.10,<3.11.0a0 *, which can be installed;
      │  ├─ pyscal3 3.3.0 would require
      │  │  └─ python >=3.11,<3.12.0a0 *, which can be installed;
      │  └─ pyscal3 3.3.0 would require
      │     └─ python >=3.12,<3.13.0a0 *, which can be installed;

@jan-janssen
Copy link
Member Author

Wait for conda-forge/pyscal3-feedstock#36

@jan-janssen jan-janssen closed this Oct 1, 2025
@jan-janssen jan-janssen reopened this Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.13%. Comparing base (869a1f8) to head (7b8f4d9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          25       25           
  Lines        1862     1862           
=======================================
  Hits         1548     1548           
  Misses        314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 120a4a6 into main Oct 1, 2025
90 of 150 checks passed
@jan-janssen jan-janssen deleted the py313 branch October 1, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants