Skip to content

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Oct 7, 2025

Summary by CodeRabbit

  • New Features
    • No user-facing feature changes in this release.
  • Chores
    • Updated dependency pin: nglview set to version 3.1.4 across environment and optional install configurations.
    • Aligned conda environment and optional dependencies for consistency.
  • Notes
    • If you rely on the optional 3D viewing component, reinstall or update your environment to ensure nglview 3.1.4 is used.
    • No other dependencies or configurations were changed.

@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025

Walkthrough

Downgrades the nglview dependency from version 4.0 to 3.1.4 in both the CI Conda environment and the project’s optional dependencies. No other changes.

Changes

Cohort / File(s) Summary
NGLView version downgrade
\.ci_support/environment.yml, pyproject.toml
Pin nglview from 4.0 to 3.1.4 in CI environment and [project.optional-dependencies]. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hop through deps with tidy cheer,
Pinning views to versions dear.
From four to three-point-one-four-four,
Fewer surprises at build’s door.
Thump-thump! The pipeline’s right on track—
Carrot-coded, never slack. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely states the main change of the pull request by specifying the downgrade of nglview to version 3.1.4, matching the actual modifications in both the environment.yml and pyproject.toml files.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert_nglview

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f901fc and 01592dc.

📒 Files selected for processing (2)
  • .ci_support/environment.yml (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: unittest_matrix (windows-latest, 3.13, win-64-py-3-13)
  • GitHub Check: unittest_old
  • GitHub Check: unittest_matrix (macos-latest, 3.13, osx-64-py-3-13)
🔇 Additional comments (2)
.ci_support/environment.yml (1)

10-10: Downgrade looks good.

Pinning nglview to 3.1.4 here matches the optional dependency and keeps CI consistent with the package metadata.

pyproject.toml (1)

46-46: Optional extra remains consistent.

Downgrading the nglview extra to 3.1.4 keeps the project metadata aligned with the CI environment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.13%. Comparing base (120a4a6) to head (01592dc).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          25       25           
  Lines        1862     1862           
=======================================
  Hits         1548     1548           
  Misses        314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit c2a55eb into main Oct 7, 2025
18 checks passed
@jan-janssen jan-janssen deleted the revert_nglview branch October 7, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants