-
Notifications
You must be signed in to change notification settings - Fork 2
Update for brain decoding demo #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the brain decoding tutorial by adding a generic data-loading utility, updating configuration defaults for faster Colab runs, and including manifests for downloading precomputed data from Google Drive.
- Introduces
load_datafunction and JSON manifests for automated data fetch - Updates default experiment settings (atlas, search/solver iterations, random state)
- Refines preprocessing and parsing modules exports
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tutorials/brain-disorder-diagnosis/preprocess.py | Renamed and exported preprocessing functions via __all__ |
| tutorials/brain-disorder-diagnosis/parsing.py | Exported compile_results and adjusted module exports |
| tutorials/brain-disorder-diagnosis/manifests/atlas.json | Added manifest entries for atlas directories |
| tutorials/brain-disorder-diagnosis/manifests/abide.json | Added manifest entries for ABIDE connectivity and phenotypes files |
| tutorials/brain-disorder-diagnosis/experiments/base.yml | Switched default atlas to hcp-ica, reduced search iterations, set random state |
| tutorials/brain-disorder-diagnosis/data.py | New load_data implementation with download helpers for manifests |
| tutorials/brain-disorder-diagnosis/config.py | Changed default data path, expanded and restructured config options |
Comments suppressed due to low confidence (2)
tutorials/brain-disorder-diagnosis/parsing.py:9
- [nitpick] This reassigns
MODELand shadows the original list. Consider using a distinct name (e.g.,MODEL_DISPLAY_NAMES) for the mapping to avoid confusion.
MODEL = {model: " ".join(model.split("_")).title() for model in MODEL}
tutorials/brain-disorder-diagnosis/config.py:11
- Several previously supported dataset options (e.g., BANDPASS, GLOBAL_SIGNAL_REGRESSION) were removed in this PR. This is a breaking change—consider deprecating them or updating downstream code accordingly.
_C.DATASET.PATH = DEFAULT_DIR
load_datafunction and data manifests to load pre-computed functional connectivity directly from Google Drive usinggdown.pandasimport error due tonumpy2.0 by using--userflag duringpip installand prependssite-packageswhen a Colab runtime is detected.config.pynow aims to reproduce intra-site evaluation in (Kunda et al., TMI 2022) with logistic regression andbase.ymlis used to optimize runtime in Colab.NUM_SEARCH_ITERandNUM_SOLVER_ITERto allow quicker runtime in Colab forbase.yml. Latest estimated runtime: 11 minutes 30 seconds.HCP-ICAatlas with 32 ROIs as default forbase.yml, ensuring quicker runtime.Note: Once the PR is approved, the Colab handle needs to be updated to clone the
mainbranch instead ofbrain-decodingbranch.