Fix J2534: ERR_CONCURRENT_API_CALL with using Pulsar #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will test Semaphore tomorrow with Pulsar.. |
Contributor
Author
|
Hmm.. I think this should be around in queries with all Connection classes. Why reading is async from main thread? I think reading thread must be started when we want.
Its steps creating queue of all queries. In one time handling one request-response. |
Contributor
Author
Works perfectly ✨ |
Owner
|
Is this a work in progress or ready to be merged? |
Contributor
Author
|
I think ready for merge. i can improve this for all connections. Maybe its a newer version 2.x will be? But i can test only j2534 |
Owner
|
No, don't touch other connections please. They are thread safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im added log_last_operation after PassThruWriteMsgs and this fix show me which real reason didnt work Pulsar correctly.
I temporarily fix this problem by adding before reading - time.sleep(0.02). Doesn't seem to be a good idea.