Skip to content

Conversation

@pylessard
Copy link
Owner

  • Report missing fields in reportWWHOBDDTCWithPermanentStatus
  • Added reportWWHOBDDTCWithPermanentStatus
  • Added a check for FunctionalGroupIdentifier match in request/response (reportWWHOBDDTCWithPermanentStatus & reportWWHOBDDTCByMaskRecord)
  • Added DtcClass class
  • fixed type hint in client dtc function that was missing the possibility to pass Severity/Status as objects
  • Moved the dtc class bit logic into the service layer
  • Improved unit testing

@pylessard
Copy link
Owner Author

@jacobs-rvw : Want to check this?

@jacobs-rvw
Copy link
Contributor

This looks ok to me. Thanks. I didn't want to mess with the Response Data originally since it wasn't needed for our use case but I'm glad you added it.

@pylessard pylessard merged commit 2f770c4 into master Mar 31, 2025
1 check passed
@pylessard pylessard mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants