Skip to content

feat: add HTTPMethod enum support to brain_http #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

feat: add HTTPMethod enum support to brain_http #2878

merged 1 commit into from
Nov 5, 2025

Conversation

@joao-faria-dev
Copy link
Contributor

@joao-faria-dev joao-faria-dev commented Nov 5, 2025

Description

HTTPMethod was added in Python 3.11 but wasn't included in the brain hints. This was raising a error mentioned on this pylint issue. This PR add that to brain_http

Closes #2877

@joao-faria-dev joao-faria-dev force-pushed the feat/add-httpmethod-enum branch from 0af06e8 to d81351f Compare November 5, 2025 02:19
@Pierre-Sassoulas Pierre-Sassoulas added the Brain 🧠 Needs a brain tip label Nov 5, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.2 milestone Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@aca2802). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2878   +/-   ##
=======================================
  Coverage        ?   93.30%           
=======================================
  Files           ?       92           
  Lines           ?    11194           
  Branches        ?        0           
=======================================
  Hits            ?    10445           
  Misses          ?      749           
  Partials        ?        0
Flag Coverage Δ
linux 93.17% <ø> (?)
pypy 93.30% <ø> (?)
windows 93.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_http.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@Pierre-Sassoulas Pierre-Sassoulas merged commit ff7205c into pylint-dev:main Nov 5, 2025
21 checks passed
pylint-backport bot pushed a commit that referenced this pull request Nov 5, 2025
@joao-faria-dev @pylint-backport
feat: add HTTPMethod enum support to brain_http (#2878)
ef66b37 
Closes #2877

(cherry picked from commit ff7205c)
@pylint-backport pylint-backport bot mentioned this pull request Nov 5, 2025
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 5, 2025
@pylint-backport @joao-faria-dev
[Backport maintenance/4.0.x] feat: add HTTPMethod enum support to bra…
e127630 
…in_http (#2879)

feat: add HTTPMethod enum support to brain_http (#2878)

Closes #2877

(cherry picked from commit ff7205c)

Co-authored-by: Joao Faria <joaovitorfaria.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

backport maintenance/4.0.x Brain 🧠 Needs a brain tip

Projects

None yet

Milestone

4.0.2

Development

Successfully merging this pull request may close these issues.

HTTPMethod missing from astroid http brain

2 participants

@joao-faria-dev @Pierre-Sassoulas