Python 3.7 pylint 2.0.0.dev2 AttributeError: module 'astroid.nodes' has no attribute 'CallFunc'

[fsnidely]

I'm trying to use pylint for Python 3.7, which isn't supported until pylint 2.0.0, so it is still in dev. However, I thought I would bring this here as pylint 2.0.0 fails when loading pylint_django, simply when checking the version (no file to be linted).

2062$ pylint --version
pylint 2.0.0.dev2
astroid 2.0.0.dev4
Python 3.7.0 (default, Jun 28 2018, 02:32:19) 
[GCC 5.4.0 20160609]

Fails when loading the plugin pylint_django:

2061$ pylint --version --load-plugins pylint_django
Traceback (most recent call last):
  File "/home/ferd/.virtualenvs/python37/bin/pylint", line 11, in <module>
    sys.exit(run_pylint())
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint/__init__.py", line 18, in run_pylint
    Run(sys.argv[1:])
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint/lint.py", line 1293, in __init__
    linter.load_plugin_modules(self._plugins)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint/lint.py", line 502, in load_plugin_modules
    module = modutils.load_module_from_name(modname)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/astroid/modutils.py", line 187, in load_module_from_name
    return load_module_from_modpath(dotted_name.split('.'), path, use_sys)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/astroid/modutils.py", line 230, in load_module_from_modpath
    module = imp.load_module(curname, mp_file, mp_filename, mp_desc)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/imp.py", line 245, in load_module
    return load_package(name, filename)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/imp.py", line 217, in load_package
    return _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint_django/__init__.py", line 7, in <module>
    from pylint_django import plugin
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint_django/plugin.py", line 9, in <module>
    from pylint_django import transforms  # noqa, pylint: disable=unused-import
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint_django/transforms/__init__.py", line 12, in <module>
    foreignkey.add_transform(MANAGER)
  File "/home/ferd/.virtualenvs/python37/lib/python3.7/site-packages/pylint_django/transforms/foreignkey.py", line 59, in add_transform
    manager.register_transform(nodes.CallFunc, inference_tip(infer_key_classes),
AttributeError: module 'astroid.nodes' has no attribute 'CallFunc'

Freeze:

astroid==2.0.0.dev4
isort==4.3.4
lazy-object-proxy==1.3.1
mccabe==0.6.1
Pillow==5.2.0
pylint==2.0.0.dev2
pylint-django==0.11.1
pylint-plugin-utils==0.3
six==1.11.0
wrapt==1.10.11

[atodorov]

@carlio I think astroid has changed some of the node names. I've seen some of the different node names at a pylint workshop I held recently.

How do we want to handle this? Try to be backwards and forwards compatible or just require newer astroid/pylint as dependencies ?

[rdrey]

I'm struggling to install pylint_django in py3.7 with pipenv because the constraint astroid<2.0 is not playing well with pylint>=2.0.0.dev2. Could you maybe release your own dev / --pre version of pylint-django?

[federicobond]

astroid 2.0 is Python 3 only, so I think we should be compatible with previous versions until support for Django 1.11 is dropped.

If we can get a Pylint 2.x build running in CI (with failures ignored for now), I can tackle some of these issues, but I don’t know enough tox to do it.

Update: pylint-plugin-utils has dropped support for Python 2, so we don't have much of a choice here.

[ramaprv]

Any updates on this ?

[atodorov]

I've been trying to get Travis to execute tests with Python 3.7 and the latest pylint/astroid but without luck. @federicobond my code is in py37-pylint-dev branch if you want to take a look.

[carlio]

@atodorov I think that keeping compat/backwards support layers is probably not worth it any more unless it's easy. There are lots of changes to django, astroid, pylint and python so it really becomes hard to keep everything going. Certainly when I tried that with this and other libs it made the code worse ans therefore the library I was writing worse, and added lots of additional vectors for bugs...

Simple things is fine, see this for example https://github.com/PyCQA/pylint-plugin-utils/blob/master/pylint_plugin_utils/__init__.py#L2 so I think a mild 'compat.py' isn't a huge problem for just renaming nodes etc, but I wouldn't put too much emphasis on keeping old versions of libs working with new versions of pylint-django.

If you're using old pylint/old django then use old pylint-django!

[carlio]

pylint 2.0 and android 2.0 just got released which might affect this.

[atodorov]

@carlio I'm still not quite sure how to reproduce locally.

Everything was working fine for me with pylint/astroid 2.0 but an older pylint-plugin-utils.

With pylint-plugin-utils 0.3 and pylint/astroid 2.0 I see the traceback from comment #0. I also see you've merged a PR that seems related. Maybe we need a new version of pylint-plugin-utils and to bump the minimum required version in setup.py ?

[carlio]

@atodorov I can bump the pylint-plugin-utils release, also I can add you to that team/group if you like (as far as I know only pylint-django uses it a lot, pylint-celery isn't used much).

[carlio]

@atodorov pylint-plugin-utils 0.4 just released. I didn't pin the pylint version in that lib, that's something that should be chosen in the pylint-django (or other plugin) libs I feel.