Don't emit unsubscriptable-object for string annotations #6536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We previously checked if a class is explicitly mentioned in PEP 585 as being subscriptable. That frequently results in errors as some classes are only generic in type stubs. We could continue to update the set of subscriptable names, but that still wouldn't cover custom packages and is impractical.
With this PR, pylint will ignore all string annotations (explicit or via
from __future__ import annotations). We might miss a few issues, however those aren't runtime errors and a type checker is likely used anyway witch would catch these.Not emitting false-positives is more important than catching all errors here IMO.
Closes #4369
Closes #6523