Optimize effect of disabling import warnings #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwright
force-pushed
the
master-shopify
branch
from
194782f to
89afdf6
Compare
Disabling 'wrong-import-order' or 'wrong-import-position' for a single line now prevents that line from triggering violations on subsequent lines.
erikwright
force-pushed
the
master-shopify
branch
from
89afdf6 to
b88c817
Compare
|
@PCManticore I don't appear to have permission to request a review. This PR fixes #1336 on |
Disabling 'ungrouped-imports' for a single line now prevents that line from triggering violations on subsequent lines.
|
This looks reasonable @erikwright ! Sorry for getting so late to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1336 on
master.