Skip to content

Prevent false positive undefined-variable for user-specified builtins given type annotations #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2022
Merged

Prevent false positive undefined-variable for user-specified builtins given type annotations #6392

merged 6 commits into from
Apr 19, 2022

Conversation

@jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

One of the code paths for undefined-variable wasn't checking the --additional-builtins option.

Closes #6388

@jacobtylerwalls jacobtylerwalls added Bug 🪲 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels Apr 19, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.13.6 milestone Apr 19, 2022
@jacobtylerwalls jacobtylerwalls changed the title Prevent false positive for user-specified builtins given type annotations Prevent false positive undefined-variable for user-specified builtins given type annotations Apr 19, 2022
jacobtylerwalls
jacobtylerwalls commented Apr 19, 2022
View reviewed changes
@coveralls
Copy link

coveralls commented Apr 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2190786185

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0003%) to 95.166%
Totals Coverage Status
Change from base Build 2190638605: 0.0003%
Covered Lines: 15788
Relevant Lines: 16590
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@DanielNoord DanielNoord merged commit ae5ed5c into pylint-dev:main Apr 19, 2022
@jacobtylerwalls jacobtylerwalls deleted the only-type-assigment-actually-builtin branch April 19, 2022 19:13
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Apr 20, 2022
Pierre-Sassoulas pushed a commit that referenced this pull request Apr 20, 2022
@jacobtylerwalls @Pierre-Sassoulas
Prevent false positive undefined-variable for user-specified builti…
ddca4dd 
…ns given type annotations (#6392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees

No one assigned

Labels

Backported Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Milestone

2.13.6

Development

Successfully merging this pull request may close these issues.

Type-hinted additional-builtins raise error since 2.12

4 participants

@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord