Skip to content

Add pattern validation to Form Validator #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2017
Merged

Add pattern validation to Form Validator #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cc30a6
Split validation test file into seperated files.
memlucky71 Jun 24, 2017
83df590
Rename controller actions to REST action in validation test cases.
memlucky71 Jun 24, 2017
115c711
Add pattern validation to Form Validation, closes #48
memlucky71 Jun 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
637 changes: 0 additions & 637 deletions restfulpy/tests/test_validation.py
View file
Open in desktop

This file was deleted.

79 changes: 79 additions & 0 deletions restfulpy/tests/test_validation_blacklist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import copy
import unittest

from nanohttp import context, json, settings

from restfulpy.principal import DummyIdentity
from restfulpy.testing import WebAppTestCase
from restfulpy.tests.helpers import MockupApplication
from restfulpy.validation import validate_form
from restfulpy.controllers import RestController, RootController


class ValidationBlackListController(RestController):
@json
@validate_form(blacklist=['blacklistParamForAll'],
client={'blacklist': ['blacklistParamForClient']},
admin={'blacklist': ['blacklistParamForAdmin']})
def post(self):
result = copy.deepcopy(context.form)
result.update(context.query_string)
return result


class Root(RootController):
validation = ValidationBlackListController()


class ValidationBlackListTestCase(WebAppTestCase):
application = MockupApplication('MockupApplication', Root())

@classmethod
def configure_app(cls):
super().configure_app()
settings.merge("""
logging:
loggers:
default:
level: info
""")

def test_validation_blacklist(self):
# Test `blacklist`
# role -> All
self.wsgi_app.jwt_token = DummyIdentity().dump().decode()
self.request('All', 'POST', '/validation', doc=False)
self.request('All', 'POST', '/validation', doc=False, params={'customParam': 'param'})
self.request('All', 'POST', '/validation', doc=False, params={'blacklistParamForAll': 'param'},
expected_status=400)
self.request('All', 'POST', '/validation', doc=False, params={'blacklistParamForClient': 'param'})
self.request('All', 'POST', '/validation', doc=False, params={'blacklistParamForAdmin': 'param'})
# -----------------------------
# role -> Client
self.wsgi_app.jwt_token = DummyIdentity('client').dump().decode()
self.request('Client', 'POST', '/validation', doc=False)
self.request('Client', 'POST', '/validation', doc=False, params={'customParam': 'param'})
self.request('Client', 'POST', '/validation', doc=False, params={'blacklistParamForAll': 'param'},
expected_status=400)
self.request(
'Client', 'POST', '/validation', doc=False,
params={'blacklistParamForClient': 'param'},
expected_status=400
)
self.request('Client', 'POST', '/validation', doc=False, params={
'blacklistParamForAdmin': 'param'
})
# -----------------------------
# role -> Admin
self.wsgi_app.jwt_token = DummyIdentity('admin').dump().decode()
self.request('Admin', 'POST', '/validation', doc=False)
self.request('Admin', 'POST', '/validation', doc=False, params={'customParam': 'param'})
self.request('Admin', 'POST', '/validation', doc=False, params={'blacklistParamForAll': 'param'},
expected_status=400)
self.request('Admin', 'POST', '/validation', doc=False, params={'blacklistParamForClient': 'param'})
self.request('Admin', 'POST', '/validation', doc=False, params={'blacklistParamForAdmin': 'param'},
expected_status=400)


if __name__ == '__main__': # pragma: no cover
unittest.main()
135 changes: 135 additions & 0 deletions restfulpy/tests/test_validation_exact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
import copy
import unittest

from nanohttp import context, json, settings

from restfulpy.principal import DummyIdentity
from restfulpy.testing import WebAppTestCase
from restfulpy.tests.helpers import MockupApplication
from restfulpy.validation import validate_form
from restfulpy.controllers import RestController, RootController


class ValidationController(RestController):

@json
@validate_form(exact=['exactParamForAll'],
client={'exact': ['exactParamForClient']},
admin={'exact': ['exactParamForAdmin']})
def post(self):
result = copy.deepcopy(context.form)
result.update(context.query_string)
return result


class Root(RootController):
validation = ValidationController()


class ValidationExactTestCase(WebAppTestCase):
application = MockupApplication('MockupApplication', Root())

@classmethod
def configure_app(cls):
super().configure_app()
settings.merge("""
logging:
loggers:
default:
level: info
""")

def test_validation_exact(self):
# Test `exact`
# role -> All
self.wsgi_app.jwt_token = DummyIdentity().dump().decode()
result, ___ = self.request('All', 'POST', '/validation', doc=False, params={'exactParamForAll': 'param'})
self.request('All', 'POST', '/validation', doc=False, expected_status=400)
self.request(
'All', 'POST', '/validation', doc=False,
params={
'exactParamForAll': 'param',
'exactParamForCustom': 'param',
},
expected_status=400
)
self.request('All', 'POST', '/validation', doc=False, params={'exactParamForCustom': 'param'},
expected_status=400)
self.assertIn('exactParamForAll', result)
self.request(
'All', 'POST', '/validation', doc=False,
params={
'exactParamForAll': 'param',
'exactParamForClient': 'param',
},
expected_status=400
)
# -----------------------------
# role -> Client
self.wsgi_app.jwt_token = DummyIdentity('client').dump().decode()

result, ___ = self.request(
'Client', 'POST', '/validation', doc=False,
params={
'exactParamForAll': 'param',
'exactParamForClient': 'param',
}
)
self.assertIn('exactParamForClient', result)
self.assertIn('exactParamForAll', result)

self.request(
'Client', 'POST', '/validation', doc=False,
params={
'exactParamForAll': 'param',
'exactParamForClient': 'param',
'exactParamForAdmin': 'param',
},
expected_status=400
)

# -----------------------------
# role -> Admin
self.wsgi_app.jwt_token = DummyIdentity('admin').dump().decode()

result, ___ = self.request('Admin', 'POST', '/validation', doc=False, params={
'exactParamForAll': 'param',
'exactParamForAdmin': 'param',
})
self.assertIn('exactParamForAdmin', result)
self.assertIn('exactParamForAll', result)

self.request('Admin', 'POST', '/validation', doc=False, params={
'exactParamForAll': 'param',
'exactParamForClient': 'param',
'exactParamForAdmin': 'param',
}, expected_status=400)

# ------------------------------------------------------------

# Test query string
self.wsgi_app.jwt_token = DummyIdentity('admin').dump().decode()
result, ___ = self.request(
'Admin', 'POST', '/validation', doc=False,
query_string={
'exactParamForAll': 'param',
},
params={
'exactParamForAdmin': 'param',
}
)
self.assertIn('exactParamForAdmin', result)
self.assertIn('exactParamForAll', result)

self.request(
'Admin', 'POST', '/validation', doc=False,
query_string={
'exactParamForAll': 'param',
'exactParamForClient': 'param',
},
params={'exactParamForAdmin': 'param'}, expected_status=400
)


if __name__ == '__main__': # pragma: no cover
unittest.main()
94 changes: 94 additions & 0 deletions restfulpy/tests/test_validation_exclude.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import copy
import unittest

from nanohttp import context, json, settings

from restfulpy.principal import DummyIdentity
from restfulpy.testing import WebAppTestCase
from restfulpy.tests.helpers import MockupApplication
from restfulpy.validation import validate_form
from restfulpy.controllers import RestController, RootController


class ValidationExcludeController(RestController):

@json
@validate_form(exclude=['excludedParamForAll'],
client={'exclude': ['excludedParamForClient']},
admin={'exclude': ['excludedParamForAdmin']})
def post(self):
result = copy.deepcopy(context.form)
result.update(context.query_string)
return result


class Root(RootController):
validation = ValidationExcludeController()


class ValidationExcludeTestCase(WebAppTestCase):
application = MockupApplication('MockupApplication', Root())

@classmethod
def configure_app(cls):
super().configure_app()
settings.merge("""
logging:
loggers:
default:
level: info
""")

def test_validation_exclude(self):
# Test `exclude`
# role -> All
self.wsgi_app.jwt_token = DummyIdentity().dump().decode()
result, ___ = self.request(
'All', 'POST', '/validation', doc=False,
params={
'customParam': 'param',
'excludedParamForAll': 'param',
'excludedParamForClient': 'param',
'excludedParamForAdmin': 'param',
}
)
self.assertIn('customParam', result)
self.assertIn('excludedParamForClient', result)
self.assertIn('excludedParamForAdmin', result)
self.assertNotIn('excludedParamForAll', result)
# -----------------------------
# role -> Client
self.wsgi_app.jwt_token = DummyIdentity('client').dump().decode()
result, ___ = self.request(
'Client', 'POST', '/validation', doc=False,
params={
'customParam': 'param',
'excludedParamForAll': 'param',
'excludedParamForClient': 'param',
'excludedParamForAdmin': 'param',
}
)
self.assertIn('customParam', result)
self.assertNotIn('excludedParamForClient', result)
self.assertIn('excludedParamForAdmin', result)
self.assertNotIn('excludedParamForAll', result)
# -----------------------------
# role -> Admin
self.wsgi_app.jwt_token = DummyIdentity('admin').dump().decode()
result, ___ = self.request(
'Admin', 'POST', '/validation', doc=False,
params={
'customParam': 'param',
'excludedParamForAll': 'param',
'excludedParamForClient': 'param',
'excludedParamForAdmin': 'param',
}
)
self.assertIn('customParam', result)
self.assertIn('excludedParamForClient', result)
self.assertNotIn('excludedParamForAdmin', result)
self.assertNotIn('excludedParamForAll', result)


if __name__ == '__main__': # pragma: no cover
unittest.main()
Loading