Skip to content

Don't return tuple from jax.scipy.linalg.qr when mode = 'r' #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+14 −1
Merged

Don't return tuple from jax.scipy.linalg.qr when mode = 'r' #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pytensor/link/jax/dispatch/slinalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ def jax_funcify_QR(op, **kwargs):
mode = op.mode

def qr(x, mode=mode):
return jax.scipy.linalg.qr(x, mode=mode)
res = jax.scipy.linalg.qr(x, mode=mode)
return res[0] if len(res) == 1 else res

return qr

Expand Down
12 changes: 12 additions & 0 deletions tests/link/jax/test_slinalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,15 @@ def test_jax_expm():
out = pt_slinalg.expm(A)

compare_jax_and_py([A], [out], [A_val])


@pytest.mark.parametrize("mode", ["full", "r"])
def test_jax_qr(mode):
# "full" and "r" modes are tested because "full" returns two matrices (Q, R), while (R,) returns only one.
# Pytensor does not return a tuple when only one output is expected.
rng = np.random.default_rng(utt.fetch_seed())
A = pt.tensor(name="A", shape=(5, 5))
A_val = rng.normal(size=(5, 5)).astype(config.floatX)
out = pt_slinalg.qr(A, mode=mode)

compare_jax_and_py([A], out, [A_val])