Remove useless pylint disable in "pymodbus". (#843)

Author: janiversen

pymodbus/bit_read_message.py

@@ -2,7 +2,6 @@
 --------------------------------------
 
 """
-# pylint: disable=R0801
 import struct
 from pymodbus.pdu import ModbusRequest
 from pymodbus.pdu import ModbusResponse

pymodbus/bit_write_message.py

@@ -3,7 +3,6 @@
 
 TODO write mask request/response
 """
-# pylint: disable=R0801
 import struct
 from pymodbus.constants import ModbusStatus
 from pymodbus.pdu import ModbusRequest

pymodbus/client/asynchronous/async_io/__init__.py

@@ -209,7 +209,7 @@ def write_transport(self, packet):
         return self.transport.sendto(packet)
 
 
-class ReconnectingAsyncioModbusTcpClient: # pylint: disable=too-many-instance-attributes
+class ReconnectingAsyncioModbusTcpClient:
     """ Client to connect to modbus device repeatedly over TCP/IP. """
     #: Minimum delay in milli seconds before reconnect is attempted.
     DELAY_MIN_MS = 100
@@ -453,7 +453,7 @@ def _create_protocol(self):
         protocol.factory = self
         return protocol
 
-class ReconnectingAsyncioModbusUdpClient: # pylint: disable=too-many-instance-attributes
+class ReconnectingAsyncioModbusUdpClient:
     """ Client to connect to modbus device repeatedly over UDP. """
 
     #: Reconnect delay in milli seconds.
@@ -669,12 +669,12 @@ def protocol_lost_connection(self, protocol):
                           'callback called while not connected.')
 
 
-class AsyncioModbusSerialClient: # pylint: disable=too-many-instance-attributes
+class AsyncioModbusSerialClient:
     """ Client to connect to modbus device over serial. """
     transport = None
     framer = None
 
-    def __init__(self, port, protocol_class=None, framer=None,  loop=None, # pylint: disable=too-many-arguments
+    def __init__(self, port, protocol_class=None, framer=None,  loop=None,
                  baudrate=9600, bytesize=8, parity='N', stopbits=1, **serial_kwargs):
         """ Initializes Asyncio Modbus Serial Client
         :param port: Port to connect
@@ -772,7 +772,7 @@ async def init_tcp_client(proto_cls, loop, host, port, **kwargs):
     return client
 
 
-async def init_tls_client(proto_cls, loop, host, port, sslctx=None,  # pylint: disable=too-many-arguments
+async def init_tls_client(proto_cls, loop, host, port, sslctx=None,
                     server_hostname=None, framer=None, **kwargs):
     """ Helper function to initialize tcp client
     :param proto_cls:

pymodbus/client/asynchronous/deprecated/asynchronous.py

@@ -31,7 +31,6 @@ def process():
        reactor.callLater(1, process)
        reactor.run()
 """
-# pylint: disable=R0801
 import logging
 from twisted.internet import defer, protocol
 from twisted.python.failure import Failure

pymodbus/client/asynchronous/factory/serial.py

@@ -1,6 +1,5 @@
 """ Factory to create asynchronous serial clients based on twisted/tornado/asyncio
 """
-# pylint: disable=R0801
 from __future__ import unicode_literals
 from __future__ import absolute_import
 import logging

pymodbus/client/asynchronous/factory/tcp.py

@@ -1,6 +1,5 @@
 """ Factory to create asynchronous tcp clients based on twisted/tornado/asyncio
 """
-# pylint: disable=R0801
 from __future__ import unicode_literals
 from __future__ import absolute_import
 import logging
@@ -48,7 +47,7 @@ def reactor_factory(host="127.0.0.1", port=Defaults.Port, framer=None, # pylint:
     return protocol, deferred
 
 
-def io_loop_factory(host="127.0.0.1", port=Defaults.Port, framer=None, # pylint: disable=unused-argument
+def io_loop_factory(host="127.0.0.1", port=Defaults.Port, framer=None,
                     source_address=None, timeout=None, **kwargs):
     """ Factory to create Tornado based asynchronous tcp clients
     :param host: Host IP address

pymodbus/client/asynchronous/factory/tls.py

@@ -1,5 +1,4 @@
 """ Factory to create asynchronous tls clients based on asyncio. """
-# pylint: disable=R0801
 from __future__ import unicode_literals
 from __future__ import absolute_import
 import logging

pymodbus/client/asynchronous/mixins.py

@@ -31,7 +31,7 @@ def __init__(self, framer=None, timeout=2, **kwargs):
 class AsyncModbusClientMixin(BaseAsyncModbusClient):
     """ Async Modbus client mixing for UDP and TCP clients. """
 
-    def __init__(self, host="127.0.0.1", port=Defaults.Port, framer=None, # pylint: disable=too-many-arguments
+    def __init__(self, host="127.0.0.1", port=Defaults.Port, framer=None,
                  source_address=None, timeout=None, **kwargs):
         """ Initializes a Modbus TCP/UDP asynchronous client
         :param host: Host IP address

pymodbus/client/asynchronous/tcp.py

@@ -1,5 +1,4 @@
 """TCP communication."""
-# pylint: disable=R0801
 from __future__ import unicode_literals
 from __future__ import absolute_import
 
@@ -17,7 +16,7 @@ class AsyncModbusTCPClient: # pylint: disable=too-few-public-methods
 
         from pymodbus.client.asynchronous.tcp import AsyncModbusTCPClient
     """
-    def __new__(cls, scheduler, host="127.0.0.1", port=Defaults.Port, # pylint: disable=too-many-arguments
+    def __new__(cls, scheduler, host="127.0.0.1", port=Defaults.Port,
                 framer=None, source_address=None, timeout=None, **kwargs):
         """ Scheduler to use:
             - reactor (Twisted)

pymodbus/client/asynchronous/tornado/__init__.py

@@ -1,5 +1,4 @@
 """ Asynchronous framework adapter for tornado. """
-# pylint: disable=R0801
 from __future__ import unicode_literals
 
 import abc
@@ -268,7 +267,7 @@ def write_to_fd(self, data):
         return None
 
 
-class AsyncModbusSerialClient(BaseTornadoSerialClient): # pylint: disable=too-many-instance-attributes
+class AsyncModbusSerialClient(BaseTornadoSerialClient):
     """ Tornado based asynchronous serial client. """
 
     def __init__(self, *args, **kwargs):
@@ -314,7 +313,7 @@ def connect(self):
 
         raise gen.Return(self)
 
-    def execute(self, request=None): #NOSONAR pylint: disable=signature-differs,too-complex
+    def execute(self, request=None): #NOSONAR pylint: disable=too-complex
         """ Executes a transaction
         :param request: Request to be written on to the bus
         :return:
@@ -395,7 +394,7 @@ def _on_receive(fd, events):
         txt = f"expected_response_length = {expected_response_length}"
         _logger.debug(txt)
 
-        #NOSONAR TODO: calculate once # pylint: disable=fixme
+        #NOSONAR TODO: calculate once
         exception_response_length = self.transaction._calculate_exception_length() # pylint: disable=protected-access
 
         if self.timeout: