Skip to content

Conversation

@dhoomakethu
Copy link
Contributor

  • Improve transaction speeds for sync clients (RTU/ASCII), now retry on empty happens only when retry_on_empty kwarg is passed to client during intialization

client = Client(..., retry_on_empty=True)

  • Fix tcp servers (sync/async) not processing requests with transaction id > 255
  • Introduce new api to check if the received response is an error or not (response.isError())
  • Move timing logic to framers so that irrespective of client, correct timing logics are followed.
  • Move framers from transaction.py to respective modules
  • Fix modbus payload builder and decoder
  • Async servers can now have an option to defer reactor.run() when using Start<Tcp/Serial/Udo>Server(...,defer_reactor_run=True)
  • Fix UDP client issue while handling MEI messages (ReadDeviceInformationRequest)
  • Fix Misc examples

…Server function

2. #283 Fix BinaryPayloadDecoder/Builder issues when using with pymodbus server
3. #278 Fix issue with sync/async servers failing to handle requests with transaction id > 255
4. #221 Move timing and transcational logic to framers for sync clients
5. #221 More debug logs for sync clients
6. Misc updates with examples and minor enhancements
2. Fix unit tests
3. Update changelog
@dhoomakethu
Copy link
Contributor Author

@karlp @kierun @mrcreatd @memetb @bosnj . Please give a try/share your comments.

@dhoomakethu
Copy link
Contributor Author

I will wait for another week for others to share there review comments. The release will be on 04/23/2018 unless some serious issues come up.

@kierun
Copy link

kierun commented Apr 16, 2018

eek… Been pulled to do something else while the code I wrote is in user acceptance test which could last a few months. Due to horrid time pressure, I have no time to test the new release. I do apologies as it's a shitty thing to do to you when you have been nothing but kind.

* Fix #289 and other misc enhancements

* Replace nosetest with pytest

* Update Changelog

* serial sync client wait till timeout/some data is available in read buffer + update changelog

* serial sync client read updates when timeout is None and Zero

* fix sync client unit test and example
@dhoomakethu dhoomakethu merged commit 9d2c864 into dev Apr 26, 2018
@dhoomakethu dhoomakethu deleted the py-1.5.0 branch May 10, 2018 11:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants