Python 3.7 support #337
Python 3.7 support #337
Conversation
Renamed pymodbus.server.async to pymodbus.server.asynchronous Modified asyncio.async to use asyncio.ensure_future Added missing prompt_toolkit dependency to requirements-docs.txt Updated references in documentation Updated examples
|
The 3.7 environment is broken, cannot download python 3.7 zip |
…names Updated requirements-docs.txt to include missing modules
|
@dices looks like travis still does not really support 3.7 (refer travis-ci/travis-ci#9815). I will keep this PR open till we get an official support and builds passing. There is also another PR with python3.7 support (@cbergmiller ). Will take some time to go through the code and review. |
|
@dices on a second thought, these changes introduce a lot of backward incompatibility with respect to async clients. Also the naming convention seems off with the sync client )
|
|
Sounds ok with me. I was also a bit worried about the backward
compatibility. Once you have the dev branch ready I can make the push
request against that one. Maybe think of a shorter name instead of the long
asynchronous one. I just wanted to contribute since I am using 3.7 and
pymodbus was not working on it.
…On Thu, Sep 27, 2018 at 1:14 AM dhoomakethu ***@***.***> wrote:
@dices <https://github.com/dices> on a second thought, these changes
introduce a lot of backward incompatibility with respect to async clients.
Also the naming convention seems off with the sync client )
pymodbus.client.sync vs pymodbus.client.asynchronous. I ran some bigquery
to check the percentage of 3.7 downloads and I find the number very less to
get this to master.
How about creating a new dev branch for 3.7 and work with that till we
come to a common conclusion ?
[image: screen shot 2018-09-27 at 10 33 28]
<https://user-images.githubusercontent.com/9276974/46124287-d4483e80-c240-11e8-9d1f-b9f68954de13.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#337 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC-8apDy6-fdvlWug67nbnwGKsoFZMJpks5ufF6ngaJpZM4W1cSI>
.
|
|
@dices Thanks, I have created a new branch |
| logger = logging.getLogger(__name__) | ||
| logger.warning("Not Importing deprecated clients. " | ||
| "Dependency Twisted is not Installed") | ||
| >>>>>>> 7980f087a0ecbf24ca049849799b365892082029:pymodbus/client/async/__init__.py |
There was a problem hiding this comment.
Just a heads up, you managed to commit the merge conflict here. 😉
There was a problem hiding this comment.
Thanks for pointing this out . @dices Refer https://github.com/riptideio/pymodbus/blame/7666b9e184285d9597ce1fcc3cba9c1f21a26483/pymodbus/client/asynchronous/__init__.py
There was a problem hiding this comment.
Shame on me for doing the merge so late during the night. I did it in the wrong branch too :)
This one will be closed the new one on the correct branch has been sent
3 participants
Renamed pymodbus.server.async to pymodbus.server.asynchronous
Modified asyncio.async to use asyncio.ensure_future
Added missing prompt_toolkit dependency to requirements-docs.txt
Updated references in documentation
Updated examples
Same as previous pr but started from dev to remove the commit I did not want to have in the pull request