Skip to content

Test macOS #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 66 commits into from
Closed

Test macOS #594

wants to merge 66 commits into from

Conversation

@altendky
Copy link
Contributor

@altendky altendky commented Jan 16, 2021 •
edited
Loading

Draft for:

@altendky altendky mentioned this pull request Jan 16, 2021
Closed
2 tasks
altendky and others added 27 commits January 18, 2021 12:26
@altendky
Hackily use Twisted serial testing classes
4d2b446
@altendky
Resupport Linux too
de69322
@altendky
more hacky fixup for linux
8db334c
@altendky
even hackier
27ae242
@altendky
mocks -> bind_and_activate=False
f30e961
@altendky
fixup for linux again
47de91c
@altendky
no twisted serial on pypy
c63202f
@altendky
add gha timeout of 10 minutes
d12ae25
@altendky
platform_python_implementation
1a8f017
@altendky
maybe we do not need cryptography for tests?
b30b691
@altendky
add back cryptography to testing and conch extra to twisted for manhole
9043ba7
@altendky
install openssl in github actions windows for pypy
2f84a96
@altendky
more openssl
9da283b
@altendky
let's try choco install openssl and see where it installs
710ed9c
@altendky
more for chocolately
37fae4a
@altendky
python info before openssl
3cd4ae1
@altendky
skip pypy 64 on windows since you still get 32
63cd0ca
@altendky
use pypy's openssl build
08631ab
@altendky
env var
8ea88d0
@altendky
hmm
7b79291
@altendky
shell: bash
47dc912
@altendky
${{ env.GITHUB_WORKSPACE }}
e34a13e
@altendky
env.workspace
a6b8fb6
@altendky
github.workspace
d4e5740
@altendky
mock out socketserver.TCPServer.server_activate
d428355
@altendky
just skipif tornado serial on windows for now
a5a975b
@altendky
some more sleeps to help asyncio tests
ba6814a
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@altendky
Copy link
Contributor Author

altendky commented Mar 3, 2021

@dhoomakethu just to be sure, you are aware of the draft feature that github added... sometime in the past year? Just making sure you have a specific use for the extra draft tag.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

@altendky
Copy link
Contributor Author

altendky commented Mar 4, 2021

Included in #593 now.

@altendky altendky closed this Mar 4, 2021
@altendky altendky deleted the test_macos branch March 4, 2021 01:58
@altendky altendky mentioned this pull request Mar 4, 2021
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@altendky @dhoomakethu