BUGFIX?: self._header needs to be set to {} #599
Conversation
…ays be missed.
populateHeader() is called in isFrameReady() and checkFrame(). In isFrameReady,
populateHeader is only called 'if not self._header', and checkFrame is only called
'if isFrameReady()'.
Reset also sets self._header to {}.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Please, take a look at PR #608. It looks like they both a trying to fix the same issue in RTU framer. |
| """ | ||
| self._buffer = b'' | ||
| self._header = {'uid': 0x00, 'len': 0, 'crc': '0000'} | ||
| self._header = {} |
There was a problem hiding this comment.
Some tests in test/test_framers.py have to be changed as well.
| """ | ||
| self._buffer = b'' | ||
| self._header = {'uid': 0x00, 'len': 0, 'crc': '0000'} | ||
| self._header = {} |
There was a problem hiding this comment.
It looks like isFrameReady() can still work incorrectly in some conditions.
If framer instance receives incomplete frame with only first byte of some frame,
populateHeader() properly sets self._header['uid'] and then raises IndexError when trying to read second byte from buffer. After that isFrameReady() will not call populateHeader because self._header is not empty, but instead will fail on line return self._header and len(self._buffer) >= self._header['len'], as len key was not added to self._header
|
Yes I checked and it very much look like the same issue.. only solved better. I have not had time to check it yet... but it does look like it will solve my issue. |
3 participants
self._header needs to be set to {}. If not, the first frame would always be missed.
populateHeader() is called in isFrameReady() and checkFrame(). In isFrameReady,
populateHeader is only called 'if not self._header', and checkFrame is only called
'if isFrameReady()'.
Reset also sets self._header to {}.
I did test with a async serial connection. Does fix my problem, was only checking for one answer.