Jules - simplified bool tests, avoid crash in memoryview. #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xmap destruction. This addresses #4155. src/__init__.py: With .samples_mv, remember the memoryview and call its .release() method in Pixmap.__del__(). docs/pixmap.rst: Document improved behaviour of Pixmap.samples_mv. Also warn that Pixmap.samples_ptr is unsafe after destruction of the pixmap. tests/test_pixmap.py: Added test_4155(), check we get ValueError when accessing memoryview after Pixmap is destroyed.
|
Thanks for the quick fix! I assume it's not possible to keep a reference to the pixmap in the memory view? Because this implementation is still prone to crashes if someone "steals" the |
Collaborator
Author
|
I didn't actually try that, but it turns out that one cannot add new members to a For example So i think the fix in this PR is probably the best we can do. |
Collaborator
Author
|
Oh, and i think that if someone "steals" the (undocumented, internal) |
JorjMcKie
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.