Skip to content

Conversation

@Val3nt-ML
Copy link
Contributor

I've modified PDFMarkdownReader class to pass load_kwargs arguments to _process_doc_page and to_markdown methods. This enables to pass arguments like image parameter ones directly as follows:

PDFMarkdownReader().load_data(file_path=file_path,
                              image_path="./",
                              write_images=True,
                              image_format="png",
                             )

@Val3nt-ML Val3nt-ML changed the title Enable to pass 'load_kwargs' arguments to 'to_markdown' method Enable to pass 'load_kwargs' arguments to PDFMarkdownReader 'load_data' method Apr 7, 2025
@JorjMcKie
Copy link
Collaborator

Thank you for your contribution!
For legal reasons we require you to acknowledge and sign our Contributors License Agreement (CLA) and confirm it in this chain of posts.
Please download and read the CLA and put a comment in the chain saying "I have read and herewith accept Artifex's Contributors License Agreement."

Thank you!

@Val3nt-ML
Copy link
Contributor Author

Val3nt-ML commented Apr 8, 2025

I have read and herewith accept Artifex's Contributors License Agreement.

Btw, the [Download the Artifex Contributor License Agreement here] seems to have an issue since it doesn't trigger anything on my side.

@JorjMcKie JorjMcKie merged commit 17c00a3 into pymupdf:main Apr 8, 2025
@JorjMcKie
Copy link
Collaborator

Btw, the [Download the Artifex Contributor License Agreement here] seems to have an issue since it doesn't trigger anything on my side.

Again, thanks for your contribution.
Otherwise, you are right: we not yet implemented PyMuPDF's automatism for storing away your agreement to the CLA.
May be implemented at some later point.
In the meantime, please support us by referring to this PR for any future contribution you may have.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants