Initialize indexes in the model metaclass. #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinner-lyft
commented
Nov 10, 2021
| """ | ||
| Initialize indexes on the class. | ||
| """ | ||
| cls._indexes = {} |
There was a problem hiding this comment.
This changes current behavior where child classes now each have their own index dictionary instead of defaulting to the dictionary on the parent class.
jpinner-lyft
force-pushed
the
clean-up-index-initialization
branch
from
b7c9793 to
1b2eda4
Compare
jpinner-lyft
commented
Nov 10, 2021
| index.Meta.model = cls | ||
| if not hasattr(index.Meta, "index_name"): | ||
| index.Meta.index_name = name | ||
| cls._indexes[index.Meta.index_name] = index |
There was a problem hiding this comment.
This keeps the current broken behavior where you can have index name collisions.
ikonst
approved these changes
Nov 10, 2021
garrettheel
reviewed
Nov 10, 2021
garrettheel
approved these changes
Nov 10, 2021
jpinner-lyft
commented
Nov 10, 2021
| cls._indexes = {} | ||
| for name, index in getmembers(cls, lambda o: isinstance(o, Index)): | ||
| if not hasattr(index.Meta, "model"): | ||
| index.Meta.model = cls |
There was a problem hiding this comment.
This changes the current behavior where the class is set by any model that has the index in the class namespace. Now first write wins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary change to simplify index management before fixing #992.