Add support for generating non-abi3 pythonXY.dll#15
Conversation
ravenexp
reviewed
May 9, 2022
ravenexp
reviewed
May 9, 2022
ravenexp
previously requested changes
May 9, 2022
Collaborator
ravenexp
left a comment
ravenexp
left a comment
There was a problem hiding this comment.
LGTM in general, but I'd like to keep backwards compatibility with v0.2 unless there's a pressing need to break it.
ravenexp
approved these changes
May 10, 2022
Collaborator
ravenexp
left a comment
ravenexp
left a comment
There was a problem hiding this comment.
The new public interface looks nice, thanks everyone for suggesting and implementing it.
Are there plans to generate version-specific import libraries for the MSVC targets as well?
Then there should be at least some unit tests for that too.
Member
Author
Added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12