main: disable colors on windows

[FFY00]

It seems Windows has settings to enable/disable color support by default
and we'd have to use low level Windows APIs to force enable, so I am
just gonna remove colors altogether. Shouldn't really be a big deal as
they are only used for the ERROR and WARNING prefixes.

Signed-off-by: Filipe Laíns lains@riseup.net

[uranusjr]

How about a ready-made solution like colorama? Colours on Windows is a solved problem, build is having issue only because the current implementation is inventing wheels from scratch.

[henryiii]

I need a tears emoji reaction. I love colors... (GitHub only has 8 reactions)

[henryiii]

PS: I know that @FFY00 is against adding dependencies, but this would be a Windows-only dependency, which might be a lot less invasive? Edit: Okay, just two words colorized might be a valid loss. Still. 😢

[FFY00]

I added it as a hard dependency on windows, but not actually a runtime dependency, people wanting to use the project to bootstrap environments may skip the dependency.

I am not 100% sure of the decision, so if it causes issues for anyone, we will reconsider.

[henryiii]

I like the idea quite a bit, I think.

Note that adding comments in setup.cfg is not supported when using setup-cfg-fmt (which I love using), and the changelog entry is still unchanged, I think. (From my phone it seems to be)

[FFY00]

Oops, I forgot the changelog.

I tried putting a comment in a line itself and it got removed, but it seems appending it to a meaningful line works fine.

[FFY00]

I am gonna merge as-is, please open a PR moving colorama.init() to a different place if you care about that.