-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Document macosx_{x}_0_{arch} pattern for macOS 11+
#1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
macosx_0_{y}_{arch} patternmacosx_0_{y}_{arch} pattern for macOS 11+
| .. important:: | ||
| Platform tags are dependent on the versioning of the operating system or | ||
| platform they represent and may change over time as the underlying platform | ||
| changes its versioning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, some parts are bound by PEPs while others were defined by packaging, while again others are defined here at all (e.g., BSDs), but platforms authors are not bound by PEPs and may make changes counter to PEP assumptions. The new macOS versioning is an example of where Apple made a change counter to packaging spec assumptions, and packaging had to adapt.
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I'd like to have another approving review since I'm not a macOS user.
di
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rgommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good and correct to me, thanks @konstin.
|
Shouldn't the title be:
|
macosx_0_{y}_{arch} pattern for macOS 11+macosx_10_{y}_{arch} pattern for macOS 11+
macosx_10_{y}_{arch} pattern for macOS 11+macosx_{x}_0_{arch} pattern for macOS 11+
|
I think it was meant to be |
Following https://discuss.python.org/t/document-that-macos-platform-tags-use-minor-version-0-for-macos-11/104616: * Document that for macOS 11 and later, the platform tag is `macosx_0_{y}_{arch}` * Document that platform tags may change over time.
895c88b to
761f6bd
Compare
Following https://discuss.python.org/t/document-that-macos-platform-tags-use-minor-version-0-for-macos-11/104616:
macosx_{x}_0_{arch}Fixes #1933
📚 Documentation preview 📚: https://python-packaging-user-guide--1958.org.readthedocs.build/en/1958/