Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pep518 support: support markers in build requirements #5245

Closed
wants to merge 1 commit into from
Closed

Fix pep518 support: support markers in build requirements #5245

wants to merge 1 commit into from

Conversation

benoit-pierre
Copy link
Member

Fix #5230.

Note: there there's also an issue with extras in build requirements being ignored.

@benoit-pierre benoit-pierre force-pushed the fix_pep518_markers_in_build_requires branch from 371b39d to 06cb48b Compare April 15, 2018 21:55
@pfmoore pfmoore requested a review from pradyunsg April 16, 2018 15:01
pradyunsg
pradyunsg approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't call it fix PEP 518 support in news.

@pfmoore pfmoore mentioned this pull request Apr 16, 2018
Closed
@pfmoore
Copy link
Member

pfmoore commented Apr 16, 2018

@pradyunsg So can someone update the news fragment to accurately describe the change, please?

@benoit-pierre
Copy link
Member Author

Can this be put on hold? I'd like to see I can fix both this and the issue with extras with one patch.

@pfmoore
Copy link
Member

pfmoore commented Apr 16, 2018

I'm happy to remove the release blocker tag and defer it to 10.1.

@pradyunsg pradyunsg added type: enhancement Improvements to functionality state: blocked Can not be done until something else is done labels Apr 16, 2018
@benoit-pierre benoit-pierre mentioned this pull request Apr 17, 2018
Closed
@pfmoore pfmoore mentioned this pull request Apr 17, 2018
Closed
@benoit-pierre
Copy link
Member Author

Superseded by #5286.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation state: blocked Can not be done until something else is done type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build dependencies don't appear to support environment markers
3 participants
@benoit-pierre @pfmoore @pradyunsg