Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.3 #1342

Merged
merged 4 commits into from May 24, 2018
Merged

Drop support for EOL Python 3.3 #1342

merged 4 commits into from May 24, 2018

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 26, 2018

As suggested in #1339, as it's EOL and Tox no longer supports it.

Also remove redundant code and update other code.

@@ -1,17 +1,3 @@
__all__ = ['get_config_vars', 'get_path']

This comment has been minimized.

@pganssle

pganssle Apr 26, 2018
Member

Why drop __all__ here?

This comment has been minimized.

@hugovk

hugovk Apr 26, 2018
Author Contributor

get_config_vars and get_path have been removed from py31compat.py because Python 2.7 and 3.4+ can directly from sysconfig import get_config_vars, get_path.

This comment has been minimized.

@pganssle

pganssle Apr 26, 2018
Member

Shouldn't we change this to __all__ = [] then?

This comment has been minimized.

@hugovk

hugovk Apr 26, 2018
Author Contributor

I don't think it's necessary, if nothing is exposed.

The others don't. For example: https://github.com/pypa/setuptools/blob/master/setuptools/py36compat.py

But happy to add it if you prefer!

This comment has been minimized.

@pganssle

pganssle Apr 26, 2018
Member

I think it's probably better to be explicit, since if __all__ is not specified, from py31compat.py import * will import everything, but if __all__ is set to [] it will import nothing.

I think it also sends a clearer message that this module provides no public members.

This comment has been minimized.

@hugovk

hugovk Apr 26, 2018
Author Contributor

Updated!

@pganssle
Copy link
Member

@pganssle pganssle commented Apr 26, 2018

I think the diff coverage that is failing is not a problem. The changes seem sane in the uncovered portions, and it's just that it's changing things that aren't tested in the first place.

Per #1339, this should be deferred until the next breaking release.

@ianw ianw mentioned this pull request May 1, 2018
ianw added a commit to ianw/setuptools that referenced this pull request May 1, 2018
pytest-flake8 1.0.1 has a hard dependency on pytest>=3.5 [1], which
does not support python3.3.  Pin it until python3.3 is removed [3].

[1] tholo/pytest-flake8@25bbd3b
[2] https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
[3] pypa#1342
ianw added a commit to ianw/setuptools that referenced this pull request May 1, 2018
pytest-flake8 1.0.1 has a hard dependency on pytest>=3.5 [1], which
does not support python3.3 [2].  Pin it until python3.3 is removed
[3].

[1] tholo/pytest-flake8@25bbd3b
[2] https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
[3] pypa#1342
@ianw ianw mentioned this pull request May 1, 2018
ianw added a commit to ianw/setuptools that referenced this pull request May 1, 2018
pytest-flake8 1.0.1 has a hard dependency on pytest>=3.5 [1], which
does not support python3.3 [2].  Avoid it for python3.3 and below
until python3.3 is removed [3].

[1] tholo/pytest-flake8@25bbd3b
[2] https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
[3] pypa#1342
ianw added a commit to ianw/setuptools that referenced this pull request May 1, 2018
pytest-flake8 1.0.1 has a hard dependency on pytest>=3.5 [1], which
does not support python3.3 [2].  Avoid it for python3.3 and below
until python3.3 is removed [3].

Additionally, ensure we have a recent enough pip in travis ci to
handle multiple requirements entries.

[1] tholo/pytest-flake8@25bbd3b
[2] https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
[3] pypa#1342
ianw added a commit to ianw/setuptools that referenced this pull request May 1, 2018
pytest-flake8 1.0.1 has a hard dependency on pytest>=3.5 [1], which
does not support python3.3 [2].  Avoid it for python3.3 and below
until python3.3 is removed [3].

Additionally, ensure we have a recent enough pip in travis ci to
handle multiple requirements entries.

[1] tholo/pytest-flake8@25bbd3b
[2] https://docs.pytest.org/en/latest/changelog.html#pytest-3-3-0-2017-11-23
[3] pypa#1342
@benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented May 17, 2018

It looks like the wheel package has dropped support for it too.

@pganssle pganssle mentioned this pull request May 17, 2018
1 of 1 task complete
@pganssle
Copy link
Member

@pganssle pganssle commented May 17, 2018

@jaraco @benoit-pierre Now that wheel is starting to break the Travis build, it's probably time to land this.

Do we have any breaking changes already in master? If not, should we cut a minor release now and then land this PR?

@pganssle
Copy link
Member

@pganssle pganssle commented May 24, 2018

It's been a few days since the last release, so I think we can merge this now.

CC: @jmbowman

@pganssle pganssle merged commit 52aacd5 into pypa:master May 24, 2018
5 checks passed
5 checks passed
codecov/patch 81.81% of diff hit (target 80.9%)
Details
codecov/project 80.93% (+0.03%) compared to e078d78
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@hugovk hugovk deleted the hugovk:rm-3.3 branch May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants