Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
added unittest for _download_git #1544
pganssle left a comment
@kanikas3 and I spoke about the changes that needed to be made at the NYC PyPA sprint, but I've added explicit review comments here just as a reminder and a documentation of what needs to be done.
Overall, the goal of this test should be to make calls into the public interface and verify that they make the correct system calls. To some extent the fact that we're mocking out
Thanks @kanikas3 and @vitoace for your contributions here. Although I ended up rewriting some of the changes, your initial contribution saved me a great deal of time placing the test and understanding the basic usage we wished to test. Your commit will be included in the history and I encourage you to look at the subsequent changes for your own edification. Thanks again.