Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unittest for _download_git #1544

merged 3 commits into from Dec 14, 2018


Copy link

@kanikas3 kanikas3 commented Oct 27, 2018

Summary of changes

  • Added unittest for _download_git function


Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
Copy link

@pganssle pganssle left a comment

@kanikas3 and I spoke about the changes that needed to be made at the NYC PyPA sprint, but I've added explicit review comments here just as a reminder and a documentation of what needs to be done.

Overall, the goal of this test should be to make calls into the public interface and verify that they make the correct system calls. To some extent the fact that we're mocking out os.system is testing an implementation detail (since we could easily use subprocess instead), but I think it's a necessary evil if this isn't going to be an implementation test.

setuptools/tests/ Outdated Show resolved Hide resolved
setuptools/tests/ Outdated Show resolved Hide resolved
setuptools/tests/ Outdated Show resolved Hide resolved
Copy link

@pganssle pganssle commented Nov 5, 2018

@kanikas3 @vitoace Ping - are you still coming back to this?

Copy link

@vitoace vitoace commented Nov 5, 2018

Sorry, probably not.

@jaraco jaraco dismissed pganssle’s stale review Dec 14, 2018

Thanks Paul for the review. Given the waned interest, I've gone ahead and addressed your concerns.

Copy link

@jaraco jaraco commented Dec 14, 2018

Thanks @kanikas3 and @vitoace for your contributions here. Although I ended up rewriting some of the changes, your initial contribution saved me a great deal of time placing the test and understanding the basic usage we wished to test. Your commit will be included in the history and I encourage you to look at the subsequent changes for your own edification. Thanks again.

@jaraco jaraco merged commit 361013f into pypa:master Dec 14, 2018
5 checks passed
PyPA Sprint Weekend at Bloomberg (2018) automation moved this from Submitted PRs to Merged PRs Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants