Fix *-nspkg.pth files and imports for pkg_resources-style legacy namespaces in editable installs.
#4041
+112
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be necessary to ensure modules inside legacy namespaces import correctly even if another distribution that shares the same namespace is installed conventionally.
Contributor
Author
|
See comments on challenges for legacy namespaces in editable installs on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
*-nspkg.pthfiles in editable installs, ensuring they are unique per distribution.pkg_resources-style legacy namespaces in editable installations.Closes #4039
Pull Request Checklist
newsfragments/.(See documentation for details)