Skip to content

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented May 4, 2025

Closes #4978

@jaraco jaraco force-pushed the debt/supported-interfaces branch from 2816d58 to e7d7e72 Compare May 4, 2025 16:24
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this Jason.

I have started drafting something to integrate with your text:

https://github.com/pypa/setuptools/compare/debt/supported-interfaces...abravalheri:setuptools:supported-interfaces-suggestions?expand=1

Please feel free to have a look and borrow whatever you want from the draft (of if you don't agree just feel free to ignore).

I can see that are a couple more related pages in the docs like https://setuptools.pypa.io/en/latest/userguide/extension.html and https://setuptools.pypa.io/en/latest/deprecated/index.html. So later we may try to coordinate the content among them.

.. toctree::
:maxdepth: 1

interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we include that after quickstart?

I think I understand the need of this to be prominent, but we have 2 classes of users: "someone that wants to do something quick and simple" and "someone that wants to do something complex that requires customisation". Adding the new file before quick start may scare out the first time of users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I merged it but forgot to make this change. I've amended that in 14870dd.

@jaraco jaraco merged commit 8bfc812 into main May 11, 2025
28 of 36 checks passed
@jaraco jaraco deleted the debt/supported-interfaces branch May 11, 2025 13:12
@jaraco
Copy link
Member Author

jaraco commented May 11, 2025

I have started drafting something to integrate with your text:

https://github.com/pypa/setuptools/compare/debt/supported-interfaces...abravalheri:setuptools:supported-interfaces-suggestions?expand=1

I've incorporated these suggestions wholesale. Thanks for adding your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the supported interfaces of Setuptools

3 participants