quick fix for issue where '\s+' is passed as mfile_sep #596
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flopy written external files are often written with a leading space in the first column. If these files have a .csv extension, adding to pars to PstFrom would require
mfile_sep=r"\s+"to support consecutive delimiters. This was causing issues downstream when writing models at apply time (r"\s+"is not an accepted separator when writing!). For now scrubbing"\s+"to store' 'in apply info file.Broader question -- should we be assuming
mfile_sep=" "meansmfile_sep=r"\s+"when passed (as we do if the model file extension is not .csv) or are we better honouring what the user explicitly passes here (if they are passing the keyword arg)? My preference is for the latter (as that is what we are currently doing, it provides more flexibility, explicit > implicit, and now mult white space can now be appropriately handled.)