Add installer.subcommand field to user agent #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
installer.subcommandfield of the user agent struct, and then logs its value by serializing it usingshlex.join()as explained in #233.Test plan
The functional tests in
test_functions.pywere changed to expect asubcommandfield to be logged, and now the coverage includes:subcommandfieldsubcommandfield with a single valuesubcommandfield with multiple valuessubcommandfield with multiple values, one of them containing spaces (to be escaped by the implementation)Changes to the downloads fixture