Skip to content

AttestationPayload.from_dist should probably do SHA256 in a streaming fashion #13

@woodruffw

Description

@woodruffw

Distribution files can unfortunately be pretty large, so we should probably stream into SHA256 rather than the current sha256(dist.read_bytes()), since that'll buffer the whole thing in memory.

There should be a sha256_streaming helper within sigstore-python that we can reuse 🙂

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions