Skip to content

Conversation

@facutuesca
Copy link
Collaborator

@facutuesca facutuesca commented Jan 14, 2025

The CLI subcommand pypi-attestations verify attestation now detects also *.slsa.attestation files during verification. If both publish and SLSA attestations are present, both are verified:

pypi-attestations verify attestation  \
  --identity https://github.com/trailofbits/pypi-attestations/.github/workflows/release.yml@refs/tags/v0.0.19 \
  test/assets/pypi_attestations-0.0.19.tar.gz

OK: test/assets/pypi_attestations-0.0.19.tar.gz.publish.attestation
OK: test/assets/pypi_attestations-0.0.19.tar.gz.slsa.attestation

@facutuesca facutuesca force-pushed the ft/support-slsa-attestations branch 5 times, most recently from d94d175 to f98ed55 Compare January 14, 2025 22:18
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
@facutuesca facutuesca force-pushed the ft/support-slsa-attestations branch from f98ed55 to 5e585e9 Compare January 14, 2025 22:22
@facutuesca facutuesca requested a review from woodruffw January 14, 2025 22:25
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @facutuesca!

@woodruffw woodruffw merged commit 28d055e into main Jan 14, 2025
7 checks passed
@woodruffw woodruffw deleted the ft/support-slsa-attestations branch January 14, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants