chore(deps): upgrade sqlalchemy #13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
di
approved these changes
Jun 12, 2023
2 tasks
miketheman
force-pushed
the
miketheman/upgrade-sqlalchemy
branch
3 times, most recently
from
b386557 to
12ff294
Compare
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
We no longer need the unmaintained extension, as SQLAlchemy 2.0 provides the CITEXT extension. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Per https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#declarative-becomes-a-first-class-api Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Add comment about order. If reversed, then we get 300+ errors about interface signature mismatches wanting to have `self` which they shouldn't. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
SQLAchemy 2.0 wants us to use the `DeclarativeBase` approach to take advantage of PEP-484 type hints and mappings. The way we implemented `Event/HasEvents` makes this upgrade path challenging - the code works, but the type hints don't match up yet. Disable all the violations surfaced from our lint step, as a deferral to come back and convert more of the models over to 2.0 declarative style. Refs: https://docs.sqlalchemy.org/en/20/changelog/whatsnew_20.html Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/upgrade-sqlalchemy
branch
from
12ff294 to
aac9dba
Compare
dstufft
approved these changes
Jun 14, 2023
ewdurbin
approved these changes
Jun 14, 2023
Since we already have the `request` available in scope, use it instead of finding a new session object. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/upgrade-sqlalchemy
branch
from
be83d17 to
7cc9867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Fiedler miketheman@gmail.com