fix: update migrations code for sqlalchemy 2.0 #13948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes that were not observed during dev/test: - raw SQL now needs to be wrapped in `text()` - if using an existing Connection, it doesn't have a `connnect()` method, so we configure the existing context to use it. Follows pattern from Alembic Cookbook https://alembic.sqlalchemy.org/en/latest/cookbook.html#sharing-a-connection-across-one-or-more-programmatic-migration-commands Signed-off-by: Mike Fiedler <miketheman@gmail.com>
The response from `text()` calls is now slightly harder to compare. Consolidates comparison logic for all tests in module. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
commented
Jun 15, 2023
| ) | ||
| ) | ||
| conn.execute("COMMIT") | ||
| conn.execute(sa.text("COMMIT")) |
There was a problem hiding this comment.
This surfaced during a make initdb vs running migrations. I chose to preserve the text vs conn.commit() since the function has other semantics applicable to the running connection.
ewdurbin
approved these changes
Jun 15, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #13929
Some changes that were not observed during dev/test:
text()connnect()method, so we configure the existing context to use it.
Follows pattern from Alembic Cookbook
https://alembic.sqlalchemy.org/en/latest/cookbook.html#sharing-a-connection-across-one-or-more-programmatic-migration-commands
Signed-off-by: Mike Fiedler miketheman@gmail.com