feat: store jwks keysets based on issuer_url #18862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, any custom issuer keys would be stored alongside the "parent" keys for the service, intermingling and making it less clear which keys belong to which service. Store with the `issuer_url` instead, as redis is fine with keys using special characters, and thus allow storage and lookups for a given issuer. No migration path necessary, as an empty cache will trigger a fresh lookup and storage the first time. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any custom issuer keys would be stored alongside the "parent" keys for the service, intermingling and making it less clear which keys belong to which service.
Store with the
issuer_urlinstead, as redis is fine with keys using special characters, and thus allow storage and lookups for a given issuer.No migration path necessary, as an empty cache will trigger a fresh lookup and storage the first time.
Resolves #18845