feat: pass the issuer_url to manage jkws storage #18885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously using `self.issuer_url` didn't make a difference, as the property is configured on the resolved Publisher class, and has nothing to do with the inbound value. Resolves pypi#18845 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Raise an exception if the key isn't found, handled by the caller chain in `verify_jwt_signature()` prior to trying to decode a value with `None`. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
| return mint_token(oidc_service, unverified_jwt, request) | ||
| return mint_token(oidc_service, unverified_jwt, unverified_issuer, request) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
ewdurbin
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using
self.issuer_urldidn't make a difference, as theproperty is configured on the resolved Publisher class, and has nothing
to do with the inbound value.
Resolves #18845
Signed-off-by: Mike Fiedler miketheman@gmail.com